Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Analytics settings "Connect" button and "Connect GA4" CTA. #5914

Closed
wants to merge 3 commits into from

Conversation

techanvil
Copy link
Collaborator

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@techanvil techanvil force-pushed the followup/5621-fix-connect-button-and-cta branch from 8f3d3da to ef229bf Compare September 26, 2022 21:37
@techanvil techanvil changed the base branch from develop to main September 26, 2022 21:37
@github-actions
Copy link

github-actions bot commented Sep 26, 2022

Size Change: +70 B (0%)

Total Size: 1.51 MB

Filename Size Change
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 19.2 kB +69 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js 70.5 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 48.4 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.1 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 5.97 kB
./dist/assets/js/31-********************.js 2.8 kB
./dist/assets/js/32-********************.js 2.28 kB
./dist/assets/js/33-********************.js 3.72 kB
./dist/assets/js/34-********************.js 51.9 kB
./dist/assets/js/35-********************.js 16.1 kB
./dist/assets/js/36-********************.js 70.9 kB
./dist/assets/js/37-********************.js 31.6 kB
./dist/assets/js/38-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-activation-********************.js 28.3 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 36.4 kB
./dist/assets/js/googlesitekit-api-********************.js 9.23 kB
./dist/assets/js/googlesitekit-base-********************.js 1.13 kB
./dist/assets/js/googlesitekit-dashboard-********************.js 72.1 kB
./dist/assets/js/googlesitekit-dashboard-details-********************.js 64.4 kB
./dist/assets/js/googlesitekit-dashboard-splash-********************.js 70.3 kB
./dist/assets/js/googlesitekit-data-********************.js 2.12 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.97 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 15 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.07 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 22.7 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js 45.1 kB
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js 26.2 kB
./dist/assets/js/googlesitekit-modules-********************.js 19.7 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 68.9 kB
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js 27.9 kB
./dist/assets/js/googlesitekit-modules-optimize-********************.js 19.6 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 18.4 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 38.4 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.2 kB
./dist/assets/js/googlesitekit-modules-thank-with-google-********************.js 25.8 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B
./dist/assets/js/googlesitekit-settings-********************.js 50.8 kB
./dist/assets/js/googlesitekit-user-input-********************.js 45.2 kB
./dist/assets/js/googlesitekit-vendor-********************.js 327 kB
./dist/assets/js/googlesitekit-widgets-********************.js 16.3 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 59.7 kB
./dist/assets/js/runtime-********************.js 1.34 kB

compressed-size-action

@techanvil
Copy link
Collaborator Author

Closing as fixed in another PR.

@techanvil techanvil closed this Sep 27, 2022
@techanvil techanvil deleted the followup/5621-fix-connect-button-and-cta branch September 27, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant