Updates to Google account details in User Menu #6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.64 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
asvinb
requested changes
Feb 3, 2023
| @@ -48,6 +48,7 @@ | |||
|
|
|||
| .googlesitekit-user-menu { | |||
| background-color: $c-surfaces-background; | |||
| border-radius: 28px; | |||
There was a problem hiding this comment.
@nfmohit This is a rather odd value. To be consistent with the border radiuses we have on the site, can we not have it set to 24px? Also, let's use the $br-md variable from https://github.com/google/site-kit-wp/blob/develop/assets/sass/config/_variables-mui3.scss#L237
There was a problem hiding this comment.
Understood, I've updated it, thank you, @asvinb!
| @@ -86,7 +87,7 @@ | |||
| .googlesitekit-user-menu__details { | |||
| align-items: center; | |||
| background-color: $c-surfaces-surface; | |||
| border-radius: 16px; | |||
| border-radius: 24px; | |||
There was a problem hiding this comment.
@nfmohit Let's use $br-md here as well.
|
Thanks @nfmohit ! LGTM! |
tofumatt
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
This PR addresses the concerns raised here:
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist