Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address QA feedback on StatusMigration component. #7059

Merged
merged 4 commits into from
May 18, 2023

Conversation

kuasha420
Copy link
Contributor

@kuasha420 kuasha420 commented May 18, 2023

Summary

Addresses issue:

Relevant technical choices

  1. Adds Proper layout (Grid, Row. Cell) in StatusMigration so it shows up correctly in the widget area.
  2. Matches styles with the UA Cutoff Warning notice as it also has a CTA button and looks better (text and CTA center aligned, mobile view).
  3. Adds a progress bar while the afcClient and site are loading.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@kuasha420 kuasha420 changed the base branch from develop to main May 18, 2023 07:43
@github-actions
Copy link

Size Change: -80 B (0%)

Total Size: 1.31 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 48.7 kB +36 B (0%)
./dist/assets/js/googlesitekit-activation-********************.js 22.8 kB +1 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 32 kB -1 B (0%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.12 kB +2 B (0%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.1 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 16.3 kB -1 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 64.4 kB -2 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 76.2 kB +2 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js 21.3 kB +3 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 90.3 kB +56 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 28.6 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js 84.9 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-optimize-********************.js 19 kB +6 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 21.4 kB -6 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 50.8 kB -172 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.2 kB -1 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 40.5 kB +2 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 318 kB -3 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.5 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.55 kB
./dist/assets/js/30-********************.js 2.8 kB
./dist/assets/js/31-********************.js 2.28 kB
./dist/assets/js/32-********************.js 3.72 kB
./dist/assets/js/33-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 42.7 kB
./dist/assets/js/googlesitekit-api-********************.js 9.58 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 9.73 kB
./dist/assets/js/googlesitekit-data-********************.js 2.17 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.23 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.31 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 22.7 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B
./dist/assets/js/googlesitekit-settings-********************.js 47.5 kB
./dist/assets/js/googlesitekit-splash-********************.js 65.6 kB
./dist/assets/js/googlesitekit-widgets-********************.js 16.6 kB
./dist/assets/js/runtime-********************.js 1.26 kB

compressed-size-action

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one @kuasha420!

@techanvil techanvil merged commit c690d2c into main May 18, 2023
@techanvil techanvil deleted the fix/5628-fix-cta-padding branch May 18, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants