Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/6244 KM Widget Tile New Visitors #7100

Merged
merged 12 commits into from
May 31, 2023

Conversation

jimmymadon
Copy link
Collaborator

@jimmymadon jimmymadon commented May 28, 2023

Summary

Addresses issue:

Relevant technical choices

  • Instead of having a single reusable Metric tile component for all widget tiles, it would be better to have three separate components for the three design types of Key Metric widget tiles. These could be: MetricTileNumeric, MetricTileText and MetricTileTable. I have implemented the first one here and the rest can be implemented when designing the first of those widgets.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@jimmymadon jimmymadon changed the title Enhancement/6244-km-widget-tile-new-visitors Enhancement/6244 KM Widget Tile New Visitors May 28, 2023
@github-actions

This comment was marked as resolved.

@github-actions
Copy link

github-actions bot commented May 28, 2023

Build files for 529891c have been deleted.

Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jimmymadon. This is a good start and almost everything looks okay to me. Found a few things that we need to improve before merging. Please, take a look.

assets/js/components/ChangeBadge.js Outdated Show resolved Hide resolved
assets/js/components/ChangeBadge.js Outdated Show resolved Hide resolved
assets/js/components/ChangeBadge.stories.js Outdated Show resolved Hide resolved
assets/js/components/KeyMetrics/MetricTileNumeric.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jimmymadon. This PR almost looks good to me. Just added two more tiny comments. Please, take a look.

assets/js/components/ChangeBadge.js Show resolved Hide resolved
assets/js/components/ChangeBadge.stories.js Show resolved Hide resolved
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @jimmymadon. Approved.

@eugene-manuilov eugene-manuilov merged commit a52f436 into develop May 31, 2023
@eugene-manuilov eugene-manuilov deleted the enhancement/6244-km-widget-tile-new-visitors branch May 31, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants