-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/6244 KM Widget Tile New Visitors #7100
Enhancement/6244 KM Widget Tile New Visitors #7100
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Build files for 529891c have been deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jimmymadon. This is a good start and almost everything looks okay to me. Found a few things that we need to improve before merging. Please, take a look.
assets/js/modules/analytics-4/components/widgets/NewVisitorsWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/NewVisitorsWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/NewVisitorsWidget.stories.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jimmymadon. This PR almost looks good to me. Just added two more tiny comments. Please, take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @jimmymadon. Approved.
Summary
Addresses issue:
Relevant technical choices
Metric
tile component for all widget tiles, it would be better to have three separate components for the three design types of Key Metric widget tiles. These could be:MetricTileNumeric
,MetricTileText
andMetricTileTable
. I have implemented the first one here and the rest can be implemented when designing the first of those widgets.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist