Check for gathering data state in Search Console and Analytics before showing User Input notification. #7198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… showing User Input notification.
|
Build files for 4bc8ad5 have been deleted. |
|
Size Change: +866 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
techanvil
reviewed
Jul 6, 2023
techanvil
reviewed
Jul 7, 2023
| @@ -49,6 +50,18 @@ export function fetchMockSaveSettings() { | |||
| ); | |||
| } | |||
|
|
|||
| export function fetchMockSaveDataAvailable() { | |||
There was a problem hiding this comment.
This is added to prevent warnings in stories about POSTing to the data-available endpoint once the gathering data state has been determined.
nfmohit
requested changes
Jul 10, 2023
There was a problem hiding this comment.
Thank you for the brilliant work here, @tofumatt & @techanvil! 👍
@techanvil Regarding the tests and stories, I've left a couple of very nitpicky comments/questions which once addressed, this should be good to go.
Thank you!
Comment on lines
+130
to
+135
| body: JSON.stringify( | ||
| getAnalytics4MockResponse( | ||
| // Some of the keys are nested paths e.g. `metrics[0][name]`, so we need to convert the search params to a multi-dimensional object. | ||
| getMultiDimensionalObjectFromParams( paramsObject ) | ||
| ) | ||
| ), |
assets/js/components/KeyMetrics/KeyMetricsSetupCTAWidget.stories.js
Outdated
Show resolved
Hide resolved
techanvil
reviewed
Jul 10, 2023
| } ); | ||
|
|
||
| it( 'does render the CTA when SC and GA4 are both connected', async () => { | ||
| global._googlesitekitUserData.isUserInputCompleted = false; |
There was a problem hiding this comment.
This is no longer needed, just setting the flag via the action below now works.
nfmohit
reviewed
Jul 11, 2023
Comment on lines
+61
to
+64
| invariant( | ||
| isGatheringData !== true, | ||
| "Analytics 4 gathering data's `true` state relies on the current authentication and selected property state so is unreliable to set from a helper, and therefore unsupported." | ||
| ); |
nfmohit
approved these changes
Jul 11, 2023
tofumatt
commented
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please note that @techanvil has picked up the implementation here, and as mentioned in this comment, the original change that Matt wrote needed to be redone anyway due to changes in
develop. Therefore, please assign to @techanvil to address any code review feedback.Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist