-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format total values in KMW tiles. #7223
Conversation
Build files for 75a0085 have been deleted. |
Size Change: -10 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏻
(I noticed at least one spot where we aren't using the style: 'decimal'
format but it would probably make sense to, for consistency.)
site-kit-wp/assets/js/modules/analytics-4/components/widgets/PopularContentWidget.js
Line 117 in 75a0085
<strong>{ numFmt( fieldValue ) }</strong> |
But maybe that's intentional, and it's definitely unrelated to this change, so let's ship this 👍🏻
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist