Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/5354 dashboard sharing blocked no owner #9015

Merged
merged 8 commits into from
Jul 26, 2024

Conversation

jimmymadon
Copy link
Collaborator

@jimmymadon jimmymadon commented Jul 15, 2024

Summary

Addresses issue:

Relevant technical choices

  • Added an additional selector instead of computing recoverable module count within the react components.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Jul 15, 2024

Build files for 6979a49 have been deleted.

This comment was marked as resolved.

Copy link
Collaborator

@zutigrm zutigrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmymadon LGTM

Comment on lines 205 to 216
sprintf(
/* translators: 1: The warning message. 2: "Learn more" link. */
__(
'%1$s. <Link>%2$s</Link>',
'google-site-kit'
),
__(
'Managing user required to manage view access',
'google-site-kit'
),
__( 'Learn more', 'google-site-kit' )
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be one translatable string:

__( 'Managing user required to manage view access. <Link>Learn more</Link>', 'google-site-kit' )

@eugene-manuilov eugene-manuilov merged commit 0bb8fa2 into develop Jul 26, 2024
20 of 21 checks passed
@eugene-manuilov eugene-manuilov deleted the bug/5354-dashboard-sharing-blocked-no-owner branch July 26, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants