Enhancement/8976 Refactor Gathering Data Notification

[jimmymadon]

Summary

Addresses issue:

• Refactor GatheringDataNotification to use the new Notifications datastore #8976

Relevant technical choices

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 7.4.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Build files for 00f3f12 have been deleted.

[github-actions]

Size Change: +14.7 kB (+0.87%)

Total Size: 1.71 MB

Filename	Size	Change
./dist/assets/js/googlesitekit-activation-********************.js	23.8 kB	+3 B (+0.01%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js	59.8 kB	-24 B (-0.04%)
./dist/assets/js/googlesitekit-adminbar-********************.js	34.6 kB	+74 B (+0.21%)
./dist/assets/js/googlesitekit-api-********************.js	10 kB	-1 B (-0.01%)
./dist/assets/js/googlesitekit-components-gm2-********************.js	5.97 kB	+5 B (+0.08%)
./dist/assets/js/googlesitekit-components-gm3-********************.js	10.1 kB	-1 B (-0.01%)
./dist/assets/js/googlesitekit-data-********************.js	2.35 kB	-4 B (-0.17%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js	9.03 kB	-3 B (-0.03%)
./dist/assets/js/googlesitekit-datastore-site-********************.js	20.4 kB	+1 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js	25.3 kB	+20 B (+0.08%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js	76.9 kB	-588 B (-0.76%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js	146 kB	-756 B (-0.51%)
./dist/assets/js/googlesitekit-modules-********************.js	22.1 kB	+1 B (0%)
./dist/assets/js/googlesitekit-modules-ads-********************.js	29.5 kB	-21 B (-0.07%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	114 kB	-86 B (-0.08%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	165 kB	-163 B (-0.1%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	22.6 kB	-31 B (-0.14%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js	20.5 kB	+14 B (+0.07%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js	59 kB	+35 B (+0.06%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	32.1 kB	-7 B (-0.02%)
./dist/assets/js/googlesitekit-notifications-********************.js	20.7 kB	+16.7 kB (+413.02%)	🆘
./dist/assets/js/googlesitekit-settings-********************.js	74.4 kB	+7 B (+0.01%)
./dist/assets/js/googlesitekit-splash-********************.js	73.7 kB	-362 B (-0.49%)
./dist/assets/js/googlesitekit-user-input-********************.js	48.9 kB	-20 B (-0.04%)
./dist/assets/js/googlesitekit-vendor-********************.js	321 kB	-65 B (-0.02%)
./dist/assets/js/googlesitekit-widgets-********************.js	81.7 kB	-5 B (-0.01%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	61.8 kB	-16 B (-0.03%)
./dist/assets/js/runtime-********************.js	1.3 kB	+4 B (+0.31%)

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css	56.6 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css	846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	8.2 kB
./dist/assets/js/31-********************.js	2.76 kB
./dist/assets/js/32-********************.js	2.25 kB
./dist/assets/js/33-********************.js	3.64 kB
./dist/assets/js/34-********************.js	935 B
./dist/assets/js/35-********************.js	892 B
./dist/assets/js/36-********************.js	3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	901 B
./dist/assets/js/googlesitekit-consent-mode-********************.js	25.6 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.08 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js	9.98 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js	646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js	624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js	630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js	712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js	675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js	634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js	657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js	633 B
./dist/assets/js/googlesitekit-i18n-********************.js	3.93 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	377 B

_{compressed-size-action}

[jimmymadon]

@tofumatt I have merged develop back into this branch as there was a conflict. When retesting, I realised a small issue that rendered the ZeroDataNotification immediately after the GatheringDataNotification was rendered. Have fixed this as well.

I have now branched off from this branch to work on #9071 as mentioned on our last standup.

[tofumatt]

Looks great, just a super minor change that I can make, or we could even do in your follow-up PR to make managing the branches easier 😄

[tofumatt]

Since we're defining this here, let's update

site-kit-wp/assets/js/hooks/useViewOnly.js

Lines 40 to 45 in e572e59

	return (
	viewContext === VIEW_CONTEXT_MAIN_DASHBOARD_VIEW_ONLY ||
	viewContext === VIEW_CONTEXT_ENTITY_DASHBOARD_VIEW_ONLY ||
	viewContext === VIEW_CONTEXT_WP_DASHBOARD_VIEW_ONLY ||
	viewContext === VIEW_CONTEXT_ADMIN_BAR_VIEW_ONLY
	);

to use this same array, so the logic is at least a bit less duplicated and things don't go out-of-sync if/when we update this array 😄

[tofumatt]

@jimmymadon and I chatted on Slack and he'll fix this in the PR for #9071 👍🏻