Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UA from internal tracking #9157

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Conversation

zutigrm
Copy link
Collaborator

@zutigrm zutigrm commented Aug 7, 2024

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Aug 7, 2024

Build files for 3f0b87a have been deleted.

Copy link

github-actions bot commented Aug 7, 2024

Size Change: -1.62 kB (-0.1%)

Total Size: 1.7 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 23.7 kB -75 B (-0.32%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.8 kB -71 B (-0.12%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.4 kB -126 B (-0.36%)
./dist/assets/js/googlesitekit-api-********************.js 9.97 kB -65 B (-0.65%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.96 kB -71 B (-0.79%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.4 kB -46 B (-0.23%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.91 kB -69 B (-0.69%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.2 kB -59 B (-0.23%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 77.4 kB -80 B (-0.1%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 147 kB -59 B (-0.04%)
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB -72 B (-0.33%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB -70 B (-0.24%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 114 kB -65 B (-0.06%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 165 kB -79 B (-0.05%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB -70 B (-0.31%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 20.4 kB -70 B (-0.34%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.9 kB -74 B (-0.13%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32 kB -71 B (-0.22%)
./dist/assets/js/googlesitekit-settings-********************.js 74.3 kB -66 B (-0.09%)
./dist/assets/js/googlesitekit-splash-********************.js 74 kB -68 B (-0.09%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.8 kB -69 B (-0.14%)
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB -1 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 81.6 kB -39 B (-0.05%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.7 kB -87 B (-0.14%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 56.6 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 892 B
./dist/assets/js/36-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.96 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.35 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-notifications-********************.js 4.04 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

@zutigrm zutigrm changed the title Remove UA from internal trcking Remove UA from internal tracking Aug 7, 2024
Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the QA brief states:

Verify that UA tag ID is not present (UA-xxx), but only the GA4 one G-xxx

But it doesn't state where… should the QA involve checking for GA requests in the Analytics Debugger output? Or in the HTML output?

Can you clarify/expand on the QA Brief here? After that this is good to merge 👍🏻

@zutigrm
Copy link
Collaborator Author

zutigrm commented Aug 8, 2024

@tofumatt Thanks, that's a good point. QAB has been updated

@tofumatt tofumatt changed the base branch from main to develop August 8, 2024 19:54
@tofumatt tofumatt merged commit 5ac1de1 into develop Aug 8, 2024
27 checks passed
@tofumatt tofumatt deleted the infrastructure/9042-remove-ua branch August 8, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants