-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UA from internal tracking #9157
Conversation
Build files for 3f0b87a have been deleted. |
Size Change: -1.62 kB (-0.1%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the QA brief states:
Verify that UA tag ID is not present (
UA-xxx
), but only the GA4 oneG-xxx
But it doesn't state where… should the QA involve checking for GA requests in the Analytics Debugger output? Or in the HTML output?
Can you clarify/expand on the QA Brief here? After that this is good to merge 👍🏻
@tofumatt Thanks, that's a good point. QAB has been updated |
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist