-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/#8165 - Implement the Audience Creation Notice OAuth flow #9206
Merged
techanvil
merged 16 commits into
develop
from
enhancement/#8165-audience-creation-oauth-flow
Aug 21, 2024
Merged
Enhancement/#8165 - Implement the Audience Creation Notice OAuth flow #9206
techanvil
merged 16 commits into
develop
from
enhancement/#8165-audience-creation-oauth-flow
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate audience returning from OAuth flow.
Build files for d3e985b have been deleted. |
Size Change: +2.42 kB (+0.14%) Total Size: 1.79 MB
ℹ️ View Unchanged
|
techanvil
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @hussain-t!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
AudienceCreationNotice
component rather than moving it to the parent component as initially outlined in the IB. This approach maintains a cleaner, more encapsulated component structure and avoids unnecessary prop drilling and side effects in the existing tests.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist