Implement the secondary user variants of the "no audiences" banner. #9307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 1c8417a have been deleted. |
|
Size Change: +13 B (0%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
techanvil
force-pushed
the
enhancement/8577-secondary-user-no-audiences-banner
branch
2 times, most recently
from
fbb99d8 to
620f971
Compare
Set it to true when `configuredAudiences` is first set to a non-empty array.
…scenarios. The unreachable scenario being the case where there are no available audiences, as there will always be at least one, due to the "All Users" audience being un-archivable.
It will be ignored, but it's ok to pass it in as it simplifies settings updates for the client.
techanvil
force-pushed
the
enhancement/8577-secondary-user-no-audiences-banner
branch
from
ae40d70 to
51a3ec1
Compare
kuasha420
approved these changes
Sep 8, 2024
There was a problem hiding this comment.
@techanvil Thank you for the excellent work here. Initially I had some confusions about introducing the new didSetAudiences instead of using configuredAudiences !== null but looking at it closely, it is really necessary.
All the other changes and deviations from IB makes sense considering the updated AC.
I merged in develop to fix some merge conflicts. The VRT failures are known issues.
With all that being said, this is LGTM. 🎉
kuasha420
deleted the
enhancement/8577-secondary-user-no-audiences-banner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist