Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue / 9156 Top Cities Driving Add to Cart #9409

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

10upsimon
Copy link
Collaborator

@10upsimon 10upsimon commented Sep 25, 2024

Summary

Addresses issue:

Relevant technical choices

  • Create new TopCitiesDrivingAddToCartWidget component with applicable constants defined prior
  • Register said component where necessary within the KMW suite of logic
  • Create stories for said new component
  • Add VRT reference images for said new component

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Sep 25, 2024

Build files for 620a9aa have been deleted.

Copy link

github-actions bot commented Sep 25, 2024

Size Change: +1.64 kB (+0.09%)

Total Size: 1.85 MB

Filename Size Change
./dist/assets/js/36-********************.js 3.12 kB -1 B (-0.03%)
./dist/assets/js/googlesitekit-activation-********************.js 24 kB +49 B (+0.2%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 70.3 kB +82 B (+0.12%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.9 kB +266 B (+0.77%)
./dist/assets/js/googlesitekit-api-********************.js 10 kB +24 B (+0.24%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.96 kB +1 B (+0.02%)
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB +2 B (+0.08%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.95 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB +1 B (+0.05%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.4 kB +51 B (+0.25%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.96 kB +31 B (+0.31%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.4 kB +86 B (+0.33%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 81.6 kB +81 B (+0.1%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 155 kB +82 B (+0.05%)
./dist/assets/js/googlesitekit-modules-********************.js 22 kB +21 B (+0.1%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 32.7 kB -95 B (-0.29%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 123 kB +84 B (+0.07%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 173 kB +452 B (+0.26%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB +4 B (+0.02%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 21.9 kB +34 B (+0.16%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 59.1 kB +136 B (+0.23%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32 kB +1 B (0%)
./dist/assets/js/googlesitekit-notifications-********************.js 22.4 kB +27 B (+0.12%)
./dist/assets/js/googlesitekit-settings-********************.js 125 kB +24 B (+0.02%)
./dist/assets/js/googlesitekit-splash-********************.js 86.4 kB +39 B (+0.05%)
./dist/assets/js/googlesitekit-user-input-********************.js 60.8 kB +14 B (+0.02%)
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB +3 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 89 kB +112 B (+0.13%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62.1 kB +28 B (+0.05%)
./dist/assets/js/runtime-********************.js 1.3 kB +1 B (+0.08%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 58 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 893 B
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B

compressed-size-action

Copy link
Collaborator

@zutigrm zutigrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @10upsimon Looks good, I just left few minor comments

Copy link
Collaborator

@zutigrm zutigrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @10upsimon almost there, just few more things to adjust regarding the report options, sorry I missed it during the first iteration.

Copy link
Collaborator

@zutigrm zutigrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @10upsimon nice work. LGTM

@eugene-manuilov eugene-manuilov merged commit 9bd1859 into develop Sep 27, 2024
18 of 22 checks passed
@eugene-manuilov eugene-manuilov deleted the issue/9156-top-cities-driving-add-to-cart branch September 27, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants