-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue / 9156 Top Cities Driving Add to Cart #9409
Issue / 9156 Top Cities Driving Add to Cart #9409
Conversation
…applicable areas.
Build files for 620a9aa have been deleted. |
Size Change: +1.64 kB (+0.09%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @10upsimon Looks good, I just left few minor comments
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @10upsimon almost there, just few more things to adjust regarding the report options, sorry I missed it during the first iteration.
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.stories.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @10upsimon nice work. LGTM
Summary
Addresses issue:
Top cities driving add to cart
ACR KMW #9156Relevant technical choices
TopCitiesDrivingAddToCartWidget
component with applicable constants defined priorPR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist