Fix VRT "Failed to launch" failure and other key unstable VRTs #9412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for d6ab725 have been deleted. |
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
4 tasks
benbowler
changed the title
…-kit-wp into bug/9406-VRT-experimentation.
hussain-t
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Excellent work, @benbowler! LGTM 👍
Note: I've verified that the CI build failures are unrelated to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
I spent some time looking into possible solutions to this. I used the troubleshooting guide for Alpine Linux to update the way Chromium is installed in our Docker container.
I created a batch test GitHub action that runs the backstop tests 25X and on my first run, over ~20 tests, it didn't trigger the browser error once! However switching to a new version of Chromium did render a few tests differently so I had to accept those changes. This new version also raised some new unstable tests:
AudienceSegmentation_Dashboard_AudienceSelectionPanel_Audience_creation_noticefor unknown reasons.WPDashboardApp_WPDashboardWidgets_ReadyWithActivateAnalyticsCTAfor unknown reasons.AdSense_Module_Overview_Widgetwhich was another case of theDataBlockGroupcomponent causing issues.While here I found ways to fix these failing tests and re-ran a batch test.
My new batch test appears to pass reliably without any "Failed to launch browser" errors! It's not 100% unfortunately with some inconsistent tests failing occasionally (3/20 in my last batch test) but it is an improvement from our previous situation.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist