Enhancement/9335 SiWG Setup Banner CTA #9560
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| /** | ||
| * Site Kit by Google, Copyright 2024 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** | ||
| * External dependencies | ||
| */ | ||
| import classNames from 'classnames'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { | ||
| BREAKPOINT_SMALL, | ||
| BREAKPOINT_TABLET, | ||
| useBreakpoint, | ||
| } from '../../../../hooks/useBreakpoint'; | ||
| import { Cell, Grid, Row } from '../../../../material-components'; | ||
|
|
||
| export default function NotificationWithSVG( { | ||
| id, | ||
| title, | ||
| description, | ||
| actions, | ||
| SVG, | ||
|
There was a problem hiding this comment. Capital prop names are a bit odd. I'm guessing it's done so you can use Looks like we do this elsewhere too, so no need to change it, but I guess leaving my comment here so it's recognised 😆 There was a problem hiding this comment. Hmm, this just clearly screams that we need a component as a prop here - similar to how we use pass |
||
| } ) { | ||
| const breakpoint = useBreakpoint(); | ||
|
|
||
| // Desktop breakpoint. | ||
| let svgSizeProps = { mdSize: 8, lgSize: 6 }; | ||
| // Tablet breakpoint. | ||
| if ( breakpoint === BREAKPOINT_TABLET ) { | ||
| svgSizeProps = { mdSize: 8 }; | ||
| } | ||
| // Mobile breakpoint. | ||
| if ( breakpoint === BREAKPOINT_SMALL ) { | ||
| svgSizeProps = { smSize: 12 }; | ||
| } | ||
|
|
||
| return ( | ||
| <div className="googlesitekit-widget-context"> | ||
| <Grid className="googlesitekit-widget-area"> | ||
| <Row> | ||
| <Cell size={ 12 }> | ||
| <div | ||
| className={ classNames( | ||
| 'googlesitekit-widget', | ||
| 'googlesitekit-widget--no-padding', | ||
| 'googlesitekit-setup-cta-banner', | ||
| `googlesitekit-setup-cta-banner--${ id }` | ||
| ) } | ||
| > | ||
| <div className="googlesitekit-widget__body"> | ||
| <Grid collapsed> | ||
| <Row> | ||
| <Cell | ||
| smSize={ 12 } | ||
| mdSize={ 8 } | ||
| lgSize={ 6 } | ||
| className="googlesitekit-setup-cta-banner__primary-cell" | ||
| > | ||
| <h3 className="googlesitekit-setup-cta-banner__title"> | ||
| { title } | ||
| </h3> | ||
|
|
||
| { description } | ||
|
|
||
| { actions } | ||
| </Cell> | ||
| <Cell | ||
| alignBottom | ||
| className={ `googlesitekit-setup-cta-banner__svg-wrapper--${ id }` } | ||
| { ...svgSizeProps } | ||
| > | ||
| <SVG /> | ||
| </Cell> | ||
| </Row> | ||
| </Grid> | ||
| </div> | ||
| </div> | ||
| </Cell> | ||
| </Row> | ||
| </Grid> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't allow developers to replace the existing class name, I'd think… so we should do this instead:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but here, the class name is essentially a flag for the version we need to use for this component. Unfortunately,
googlesitekit-publisher-win__actionsandgooglesitekit-setup-cta-banner__actions-wrapperare conflicting with each other - so we can either apply one or the other. If we were to useclassnames, we would have to create another flag liketypeor something solely for styling. Type could then bebanner-notificationorsetup-cta. And then we'd have to switch the classname based on the type. Ideally, we should be refactoring the legacy banner notifications (viz. all classes withgooglesitekit-publisher-win*) soon.So is this worth add the whole type flag, etc or should I leave this as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in that case we can leave it as-is, fair enough.