Add GA event tracking for the Audiences Tiles (excluding the "Top content" metric area) #9567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_request_access`, `data_loading_error` and `data_loading_error_retry` GA actions to AudienceTileError.
…s to AudienceTile.
…udienceTileZeroData.
…_request_access`, `data_loading_error` and `data_loading_error_retry` GA actions to AudienceSegmentationErrorWidget.
…nceTileError and AudienceSegmentationErrorWidget.
…ile_partial_data_tooltip`.
… `insufficient_permissions_error_request_access`, `data_loading_error` and `data_loading_error_retry` GA actions.
…vents in AudienceTileZeroData.
…ions_error_request_access`, `data_loading_error` and `data_loading_error_retry` GA actions in AudienceSegmentationErrorWidget.
|
Build files for 3013ac3 have been deleted. |
|
Size Change: +4.56 kB (+0.24%) Total Size: 1.87 MB
ℹ️ View Unchanged
|
1 task
…op_content_partial_data_tooltip` GA events in AudienceTile.
techanvil
commented
Oct 28, 2024
There was a problem hiding this comment.
This file was moved to assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationErrorWidget/index.js, rather than deleted, but Github hasn't picked it up - probably because the moved file was then modified.
techanvil
commented
Oct 28, 2024
There was a problem hiding this comment.
This file was also moved, not deleted. It was moved to assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationErrorWidget/index.test.js
techanvil
commented
Oct 28, 2024
There was a problem hiding this comment.
This file was also moved, not deleted. It was moved to assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/AudienceTileError/index.js.
techanvil
commented
Oct 28, 2024
| @@ -498,7 +543,51 @@ describe( 'AudienceTilesWidget', () => { | |||
| ) | |||
| ).toBeInTheDocument(); | |||
|
|
|||
| await act( () => waitForTimeouts( 100 ) ); | |||
| await act( () => waitForTimeouts( 150 ) ); | |||
There was a problem hiding this comment.
This test was still proving to be a bit flaky, hence increasing the timeout which was added to improve stability.
nfmohit
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Excellent work on this, thank you @techanvil.
I've left a few comments, but as they are very minor, I'll go ahead and address them myself. Thank you!
...lytics-4/components/audience-segmentation/dashboard/AudienceSegmentationErrorWidget/index.js
Show resolved
Hide resolved
...s-4/components/audience-segmentation/dashboard/AudienceSegmentationErrorWidget/index.test.js
Outdated
Show resolved
Hide resolved
nfmohit
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist