Enhancement/#9447 - Add a survey trigger for Reader Revenue Manager CTA #9608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for cfc18f6 have been deleted. |
|
Size Change: +115 B (+0.01%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
techanvil
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Hey @hussain-t, this is looking good. Just one comment from me on the approach to testing, please take a look.
...dules/reader-revenue-manager/components/dashboard/ReaderRevenueManagerSetupCTABanner.test.js
Show resolved
Hide resolved
hussain-t
commented
Nov 5, 2024
| @@ -81,6 +88,8 @@ describe( 'ReaderRevenueManagerSetupCTABanner', () => { | |||
| } ); | |||
|
|
|||
| it( 'should render the Reader Revenue Manager setup CTA banner when not dismissed', async () => { | |||
| mockSurveyEndpoints(); | |||
There was a problem hiding this comment.
We need to retain the mockSurveyEndpoints calls to ensure the tests pass, as the survey endpoints are triggered when the banner renders. Removing them would cause the tests to fail.
techanvil
approved these changes
Nov 5, 2024
...dules/reader-revenue-manager/components/dashboard/ReaderRevenueManagerSetupCTABanner.test.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist