Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Periodic Server Requirements Health Checks Using WP-Cron Job #9808

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

ankitrox
Copy link
Collaborator

@ankitrox ankitrox commented Dec 3, 2024

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Dec 3, 2024

Build files for 3401937 have been deleted.

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this, @ankitrox. I've added a few comments, please let me know if you have any questions, thank you!

@ankitrox
Copy link
Collaborator Author

ankitrox commented Dec 5, 2024

Thanks for your kind review @nfmohit. I've made the suggested changes as they all looks valid ones and also moved the is_endpoint_healthy method inside First_Party_Mode class so that we can reuse healthcheck method as mentioned.

Assigning this over to you for another round of CR.

Thank you.

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work, thank you @ankitrox. I've added a couple more extremely minor comments, so minor that I'll address them myself, thank you!

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@nfmohit nfmohit merged commit bf1bec6 into develop Dec 6, 2024
20 checks passed
@nfmohit nfmohit deleted the enhancement/9768-health-check-cron branch December 6, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants