-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Periodic Server Requirements Health Checks Using WP-Cron Job #9808
Conversation
Build files for 3401937 have been deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this, @ankitrox. I've added a few comments, please let me know if you have any questions, thank you!
Thanks for your kind review @nfmohit. I've made the suggested changes as they all looks valid ones and also moved the Assigning this over to you for another round of CR. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work, thank you @ankitrox. I've added a couple more extremely minor comments, so minor that I'll address them myself, thank you!
includes/Core/Tags/First_Party_Mode/REST_First_Party_Mode_Controller.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist