Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installable via pip #99

Merged
merged 3 commits into from
Jun 28, 2016
Merged

Make installable via pip #99

merged 3 commits into from
Jun 28, 2016

Conversation

rzurad
Copy link
Contributor

@rzurad rzurad commented Jun 15, 2016

Greetings!

This PR adds a setup.py file so that this project can be installed via pip and used as a dependency in other python projects.

I don't spend a lot of time in Python-land, so this is the first setup.py I've ever had to create. If I forgot something or am doing something stupid, please let me know. I also didn't want to clobber version 2.0 since that's an already tagged release that isn't importable by pip, so I just assigned the version as 2.1a1.

Let me know if you need anything else from me. Thanks!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rzurad
Copy link
Contributor Author

rzurad commented Jun 15, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@rzurad
Copy link
Contributor Author

rzurad commented Jun 15, 2016

No, googlebot, thank you! 👯

@suderman-google
Copy link
Contributor

Sorry for the delay. Thanks for the fix and we are happy to accept :)

@suderman-google suderman-google merged commit f909403 into google:master Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants