Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Shridevinb/windows par #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shridevinb
Copy link

@shridevinb shridevinb commented Sep 30, 2021

This change includes a fix to #39

  • Remove the stubfile parsing when the interpreter is specified.
  • And use the interpreter as the first argument while running the compiler.par on windows, because compiler.par is not recognised as win32 application and it requires the python to invoke it. For others, the shebang is specified in the file and it works.

@google-cla
Copy link

google-cla bot commented Sep 30, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

…e the interpreter as the first argument while running the compiler.par on windows, because compiler.par is not recognised as win32 application and the shebang in not specified.
…e the interpreter as the first argument while running the compiler.par on windows, because compiler.par is not recognised as win32 application and the shebang in not specified.
@shridevinb
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@shridevinb
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@shridevinb
Copy link
Author

@googlebot I signed it!

@shridevinb
Copy link
Author

@thundergolfer can you review this change?

@thundergolfer
Copy link

@shridevinb I don't think I can. I'm not an owner of this repo so I don't think an approval would count and make the PR mergeable.

@shridevinb
Copy link
Author

@brandjon can you review the code?

@thundergolfer
Copy link

@shridevinb given

Subpar is currently owned by the maintainers of bazelbuild/rules_python, which depends on it. It is not being actively developed beyond what is needed to keep compatibility with rules_python.

from the repo, I doubt you'll get review, unfortunately. subpar is on life support only for a deprecated part of rules_python. It's effectively unmaintained.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants