Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Add no_remove flag #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add no_remove flag #84

wants to merge 2 commits into from

Conversation

q3k
Copy link

@q3k q3k commented Oct 5, 2018

This change adds a no_remove flag. Its purpose is to let users disable the atexit handler that removes the extracted archive when running a zip_safe=False parfile.

There's at least two scenarios when this is useful:

  • post mortem analysis of malfunctioning a program/par
  • environments when atexit might be spuriously called (eg. uwsgi workers being killed, while others are still running - I imagine this is due to multiprocessing)

Of course, the flag will cause disk space to get used, and the user needs to be aware of that.

@q3k
Copy link
Author

q3k commented Oct 5, 2018

@duggelz PTAL

Copy link
Contributor

@duggelz duggelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@q3k Unfortunately I no longer work for Google, and don't have commit access to this repo any longer. Change looks good to me, though.

@q3k q3k force-pushed the master branch 2 times, most recently from bb79429 to 151175d Compare July 16, 2019 11:48
Serge Bazanski and others added 2 commits July 16, 2019 13:51
@q3k
Copy link
Author

q3k commented Jul 16, 2019

cc @dkelmer @tmc

Copy link

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem reasonable to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants