-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.2.0 Jar seems to include an incoherent version number in its pom #57
Comments
I’ve caught this a few times, but this one escaped. The https://github.com/vaticle/bazel-distribution that generates pom.xml includes the exact contents of VERSION… including the trailing newline that most text editors will add by default. I would prefer to move away from this dependency. |
Hi @aaronhurst-google 👋 Thank you for your answer. Do you have an idea of what you would like to have as a replacement of this dependency? Would a PR, opened by a first time contributor, following these guidelines be considered if open? |
Root cause in Bazel distribution has been identified: typedb/bazel-distribution#380 |
Thank you for mentioning our issue! As I understand, your problem comes from the |
…17f2e4 Changes: typedb/bazel-distribution@e61daa7...8767cde Fixes google#57 in the future
…17f2e4 (#58) Changes: typedb/bazel-distribution@e61daa7...8767cde Fixes #57 in the future
Expected Behavior
The
<version>
and<tag>
XML tags have the2.2.0
valueActual Behavior
The
<version>
and<tag>
XML tags have the2.2.0\n
value, not matching the actual version https://mvnrepository.com/artifact/com.google.summit/summit-ast/2.2.0Steps to Reproduce the Problem
unzip summit-ast-2.2.0.jar
cat META-INF/maven/com.google.summit/summit-ast/pom.xml
This got identified during an investigation of an error faced during the execution of OWASP DependencyCheck: jeremylong/DependencyCheck#6688 (comment)
Specifications
2.2.0
The text was updated successfully, but these errors were encountered: