Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cover: allow paths to be excluded from stats #5804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quic-likaid
Copy link

Some sub paths may not be covered due to hardware configuration, or lack of interest. This patch allows them to be excluded from the stats. This can be convenient if the excluded paths are deep in the hierarchy:

{
    "name": "sound",
    "path": [
	"techpack/audio",
	"-techpack/audio/asoc/aaa/bbb"
	"-techpack/audio/asoc/aaa/ccc"
    ]
}

Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md


Copy link

google-cla bot commented Feb 19, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tarasmadan
Copy link
Collaborator

Hi quic-likaid.
Do you plan to use it locally only?

I'd like to better understand your motivation.

@quic-likaid
Copy link
Author

Hi @tarasmadan ,

We have a lot of modules enabled on an arm64 target , but only some of them are reachable due to hardware configuration.

If we have following paths:

techpack/audio
techpack/audio/asoc/a/1
techpack/audio/asoc/a/2
techpack/audio/asoc/a/3
techpack/audio/asoc/a/4
techpack/audio/asoc/a/5
techpack/audio/dsp

Say we want to exclude a/1 and a/2, before this patch the config is

"path": [
  "techpack/audio/asoc/a/3",
  "techpack/audio/asoc/a/4",
  "techpack/audio/asoc/a/5",
  "techpack/audio/dsp"
]

With the patch it becomes:

"path": [
  "techpack/audio",
  "-techpack/audio/asoc/a/1",
  "-techpack/audio/asoc/a/2"
]

which is hopefully clearer.

@quic-likaid
Copy link
Author

re-created the commit to trigger CLA check. (failed again..)

@tarasmadan
Copy link
Collaborator

Does it mean you have your own, manually crafted subsystem definitions and you want to have more flexible syntax to describe them?

@quic-likaid
Copy link
Author

Does it mean you have your own, manually crafted subsystem definitions and you want to have more flexible syntax to describe them?

Yes.

@a-nogikh
Copy link
Collaborator

@jiangenj did you mean to push all those commits here or was it by mistake?

@jiangenj
Copy link
Contributor

@jiangenj did you mean to push all those commits here or was it by mistake?

Thanks, it's by mistake.

@jiangenj
Copy link
Contributor

@quic-likaid still facing with the cla/google issue, perhaps it's your account setting.

@quic-likaid quic-likaid force-pushed the exclude-path branch 2 times, most recently from 24cb834 to 679ffb7 Compare February 26, 2025 02:09
Copy link
Collaborator

@tarasmadan tarasmadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to test it?

@quic-likaid
Copy link
Author

Do you plan to test it?

I did look at the existing tests before committing. It seems to me that the test (report_test.go) could not be easily extended to cover the change. It only has a dummy main function.

I'm using the change in our internal setup, and it works fine.

@quic-likaid
Copy link
Author

Added a new test.

tarasmadan
tarasmadan previously approved these changes Feb 28, 2025
@tarasmadan tarasmadan enabled auto-merge February 28, 2025 09:00
auto-merge was automatically disabled March 3, 2025 00:20

Head branch was pushed to by a user without write access

Some sub paths may not be covered due to hardware configuration, or lack
of interest. This patch allows them to be excluded from the stats. This
can be convenient if the excluded paths are deep in the hierarchy:

{
    "name": "sound",
    "path": [
	"techpack/audio",
	"-techpack/audio/asoc/aaa/bbb"
	"-techpack/audio/asoc/aaa/ccc"
    ]
}
@quic-likaid
Copy link
Author

Hi @tarasmadan , I've resolved a merge conflict. Would you please review? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants