syz-ci: upload programs coverage from managers to gcs #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tarasmadan
force-pushed
the
upload-progs-coverage-to-gcs
branch
3 times, most recently
from
cfc7315 to
62f27df
Compare
tarasmadan
force-pushed
the
upload-progs-coverage-to-gcs
branch
from
62f27df to
fccac25
Compare
a-nogikh
reviewed
Mar 6, 2025
| fileName := fmt.Sprintf("%s/%s-%s-%d-%d.jsonl", | ||
| mgr.mgrcfg.DashboardClient, | ||
| mgr.name, curTime.Format(time.DateOnly), | ||
| curTime.Hour(), curTime.Minute()) |
There was a problem hiding this comment.
Nit: not that it matters much, but do we care about hours and minutes here? If there were several restarts on the same day, is it not okay to just overwrite the jsonl?
There was a problem hiding this comment.
It costs nothing and guarantees uniqueness. The goal was to generate the human readable, unique name.
But you're probably right, it is not a big deal.
tarasmadan
force-pushed
the
upload-progs-coverage-to-gcs
branch
2 times, most recently
from
3a982d5 to
c849374
Compare
|
PTAL |
tarasmadan
force-pushed
the
upload-progs-coverage-to-gcs
branch
from
c849374 to
d18b1bd
Compare
a-nogikh
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5668 for the wider context.
#5798 needs to be landed first