Rename horizons to auto-sample-conditions #225
Conversation
| | `0.5ms` | Is A faster or slower than B by at least 0.5 milliseconds? | | ||
|
|
||
| In the following example, we have set `--horizon=10%`, meaning we are interested | ||
| ### Auto sample conditions |
There was a problem hiding this comment.
Nit: Maybe both? "Auto sample stopping conditions" - unless conditions can do more than just stop? Also no action required.
There was a problem hiding this comment.
I think I'd like to be 100% consistent with the phrase "auto sample conditions".
README.md
Outdated
| conditions_. This is controlled by the `--auto-sample-conditions` flag or the | ||
| `autoSampleConditions` JSON config option. | ||
|
|
||
| An auto sample condition condition can be thought of as a point of interest on |
There was a problem hiding this comment.
Nit: condition intended twice?
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "type": "array" |
| @@ -768,6 +768,22 @@ suite('config', () => { | |||
| 'config.benchmarks[0].packageVersions requires property "label"' | |||
| ); | |||
| }); | |||
|
|
|||
| test('Error to use both horizons and autoSampleConditions', async () => { | |||
aomarks
force-pushed
the
rename-horizons
branch
from
9e8bf54 to
cc3bb9f
Compare
aomarks
force-pushed
the
rename-horizons
branch
from
cc3bb9f to
20a2b34
Compare
|
I never liked the name "horizons" (except on the day I chose it I guess). I think a much clearer name is "auto sample conditions".
This changes the
--horizonflag and thehorizonsJSON config setting (yes... one was singular, the other plural) to--auto-sample-conditionsandautoSampleConditionsrespectively.It's backwards compatible, with a warning printed if you use the old style.
Related to #221