Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tp.begin and tp.end operators #148

Merged
merged 4 commits into from
Jun 8, 2023
Merged

tp.begin and tp.end operators #148

merged 4 commits into from
Jun 8, 2023

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Jun 7, 2023 •
edited
Loading

@achoum achoum marked this pull request as ready for review June 7, 2023 08:59
@achoum achoum requested a review from rstz June 7, 2023 08:59
ianspektor
ianspektor approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@ianspektor ianspektor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes!

One more thing: since this PR addresses most of yesterday's action items, maybe it could make sense to also replace all occurrences of evtset with evset? Up to you, we can address it in a follow up one too.

docs/src/tutorials/m5_competition.py Outdated Show resolved Hide resolved
temporian/__init__.py Outdated Show resolved Hide resolved
temporian/__init__.py Outdated Show resolved Hide resolved
temporian/core/operators/begin.py
"""Generates a single timestamp at the beginning of the input.

Args:
input: Guide input
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing full stop after description. also not sure what "Guide" means here? same goes for end op

temporian/implementation/numpy/operators/test/BUILD Outdated
Comment on lines 419 to 421
# already_there/absl/testing:absltest
# already_there/pandas
# already_there/numpy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to your PR, but could these commented external dependencies be removed from the build files or are they required for Google's internal pipelines?

@achoum achoum mentioned this pull request Jun 7, 2023
Merged
rstz
rstz approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@rstz rstz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rstz
rstz approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@rstz rstz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achoum achoum merged commit bd72f3c into main Jun 8, 2023
@achoum achoum deleted the gbm_4 branch June 8, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianspektor ianspektor ianspektor approved these changes

@rstz rstz rstz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achoum @rstz @ianspektor