Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventsetornode hints #201

Merged
merged 16 commits into from
Jul 19, 2023
Merged

Eventsetornode hints #201

merged 16 commits into from
Jul 19, 2023

Conversation

ianspektor
Copy link
Collaborator

@ianspektor ianspektor commented Jul 17, 2023

All of these are now typed correctly:
image
image
image

And no type errors are thrown in operators nor in @compile
image
image
image

Only had to add a single type ignore (and its because of the hard-to-track logic we're doing to accept arguments in the decorator, but it might be possible to type compile correctly to avoid this, though I don't think its worth the trouble)
image

@achoum
Copy link
Collaborator

achoum commented Jul 17, 2023

The design is great.

@ianspektor ianspektor requested a review from achoum July 18, 2023 17:30
Copy link
Collaborator

@achoum achoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@ianspektor ianspektor merged commit 3e7f0eb into main Jul 19, 2023
@ianspektor ianspektor deleted the eventsetornode-hints branch July 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants