-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CODE WIDE] Operator chaining #206
Conversation
@@ -96,6 +96,7 @@ plugins: | |||
group_by_category: true | |||
show_category_heading: false | |||
show_root_heading: true | |||
inherited_members: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it worked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did :) the option literally got released last week in https://github.com/mkdocstrings/python/releases/tag/1.2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what it's called being lucky :)
Opened issue to mkdocstrings-python to fix full EventSet source path being shown in docs mkdocstrings/python#90 |
Opened another issue for weird behavior when linking to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. Thanks for pulling this off!!
Nit + optional (another pr): Can you run "python tools/build_cleaner.py" to see if deps need to be updated.
@@ -96,6 +96,7 @@ plugins: | |||
group_by_category: true | |||
show_category_heading: false | |||
show_root_heading: true | |||
inherited_members: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what it's called being lucky :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and merge this one and I can update the notebooks in #202 altogether. That one is ready but not approved yet, so let's resolve this one first if it's ready now.
TODO
✅ good:
functools.wraps
doesn't work because it makes autocomplete think the function is expecting the evset as first argument, but it isn't, since it's a class method that receives self. also doesn't show up in docs.