Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator tick_calendar #255

Merged
merged 31 commits into from
Oct 4, 2023
Merged

Operator tick_calendar #255

merged 31 commits into from
Oct 4, 2023

Conversation

DonBraulio
Copy link
Collaborator

@DonBraulio DonBraulio commented Sep 7, 2023 •
edited
Loading

Implementing pretty much as discussed in pseudo-code.

I'm not using tuples for ranges (e.g: days=(1,31)), just separate parameters like min_day and max_day, because it's easier for attribute types and interfacing with C++ function.

  • Operator & C++ implementation
  • Basic docstring
  • Auto setup and control None args.
  • Unit tests
  • More docstring examples

Important changes since prev. review:

  • Using Literal['*'], handling that in typecheck.py.
  • Using attribute type ANY, serializing '*' or number.
  • Added tests for auto-parameters and invalid ranges/types.

@DonBraulio DonBraulio marked this pull request as draft September 7, 2023 19:07
@DonBraulio DonBraulio marked this pull request as ready for review September 8, 2023 16:35
achoum
achoum reviewed Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@achoum achoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.
Some comments :)

temporian/core/event_set_ops.py Outdated Show resolved Hide resolved
temporian/core/event_set_ops.py Outdated Show resolved Hide resolved
temporian/core/event_set_ops.py Outdated Show resolved Hide resolved
temporian/core/event_set_ops.py Outdated Show resolved Hide resolved
temporian/core/event_set_ops.py Show resolved Hide resolved
temporian/implementation/numpy/operators/tick_calendar.py Outdated Show resolved Hide resolved
temporian/implementation/numpy_cc/operators/tick_calendar.cc Outdated Show resolved Hide resolved
temporian/implementation/numpy_cc/operators/tick_calendar.cc Outdated Show resolved Hide resolved
temporian/core/operators/tick_calendar.py Outdated Show resolved Hide resolved
temporian/implementation/numpy/operators/test/tick_calendar_test.py Show resolved Hide resolved
@achoum achoum self-requested a review September 12, 2023 13:42
@DonBraulio DonBraulio requested review from achoum and removed request for achoum September 12, 2023 20:27
@achoum
Copy link
Collaborator

achoum commented Sep 13, 2023

Re-request review when needed

@ianspektor
Copy link
Collaborator

Please update changelog with new op + any other changes

@achoum
Copy link
Collaborator

achoum commented Sep 25, 2023

Can you "resolve" the conversations that are addressed?

achoum
achoum approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@achoum achoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@DonBraulio DonBraulio merged commit f80aafb into main Oct 4, 2023
16 checks passed
@DonBraulio DonBraulio deleted the calendar-ticks branch October 4, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achoum achoum achoum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonBraulio @achoum @ianspektor