Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update front-page #306

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Update front-page #306

merged 6 commits into from
Nov 16, 2023

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Nov 8, 2023

No description provided.

@achoum achoum marked this pull request as ready for review November 8, 2023 16:49
Copy link

github-actions bot commented Nov 8, 2023

Coverage report

Main: 91.11% | PR: 91.11% | Diff: 0.00 ✅

3 similar comments
Copy link

github-actions bot commented Nov 8, 2023

Coverage report

Main: 91.11% | PR: 91.11% | Diff: 0.00 ✅

Copy link

github-actions bot commented Nov 8, 2023

Coverage report

Main: 91.11% | PR: 91.11% | Diff: 0.00 ✅

Copy link

github-actions bot commented Nov 8, 2023

Coverage report

Main: 91.11% | PR: 91.11% | Diff: 0.00 ✅

@achoum achoum requested a review from ianspektor November 10, 2023 20:07
Copy link
Collaborator

@ianspektor ianspektor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the more to the point approach + the more complex example 👍🏼 left some grammar/spelling nits

README.md Outdated Show resolved Hide resolved
> examples of temporal data are transaction logs, sensor signals, and
> weather patterns. For more, see
> [What is Temporal data](https://temporian.readthedocs.io/en/stable/user_guide/#what-is-temporal-data).
Temporian is to [temporal data](https://temporian.readthedocs.io/en/stable/user_guide/#what-is-temporal-data) what Pandas is to tabular data.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it too :P

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rstz rstz self-requested a review November 13, 2023 14:52
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@DonBraulio DonBraulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I really like the new example 👌

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@achoum
Copy link
Collaborator Author

achoum commented Nov 15, 2023

Thank all for the tomorrow review 🙂

Copy link

Coverage report

Main: 91.13% | PR: 91.13% | Diff: 0.00 ✅

Copy link

Coverage report

Main: 91.13% | PR: 91.13% | Diff: 0.00 ✅

@achoum achoum merged commit 8aaeae7 into main Nov 16, 2023
@achoum achoum deleted the gbm_doc2 branch November 16, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants