Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

380: Initial implementation of moving_product operation #383

Merged
merged 11 commits into from
Mar 7, 2024
Merged

380: Initial implementation of moving_product operation #383

merged 11 commits into from
Mar 7, 2024

Commits on Feb 28, 2024

  1. WIP: Initial implementation of moving_product operation

    @akshatvishu
    akshatvishu committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e03ecae View commit details
    Browse the repository at this point in the history

  2. Remove the wrong use of override keyword at Reset Method in the Movin… 

    …gProductAccumulator class
    @akshatvishu
    akshatvishu committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3c42893 View commit details
    Browse the repository at this point in the history

  3. Implement On-Demand Product Calculation in MovingProductAccumulator 

    Key Changes:
- Start and end indices (`start_idx` and `end_idx`) introduced to track the window.
- `Add` and `Remove` methods updated to adjust the window indices without affecting the product.
- `Result` method now calculates the product on-demand, considering zeros and ignoring NaN values for accuracy.
- Added a TODO comment to explore future optimizations for the Result method to enhance calculation efficiency.
    @akshatvishu
    akshatvishu committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    31b197a View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. add test and doc for moving_product

    @akshatvishu
    akshatvishu committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c0a0d54 View commit details
    Browse the repository at this point in the history

  2. Optimize moving_product logic to directly return zero for windows wit… 

    …h zero values
    @akshatvishu
    akshatvishu committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    da0d3e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. fix(docs): Update docs and adjust example values for clarity in event… 

    …_set_ops.py

fix(moving_product): Update the moving_product logic to return NaN when the input only contains NaN.
    @akshatvishu
    akshatvishu committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    73ce8d8 View commit details
    Browse the repository at this point in the history

  2. feat(window_op): Add cumprod operator

    @akshatvishu
    akshatvishu committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    ad8afa9 View commit details
    Browse the repository at this point in the history

  3. style: format cumprod related files with Black

    @akshatvishu
    akshatvishu committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    ccc502a View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. docs: remove un-wanted function description from moving_product at ev… 

    …ent_set_ops.py
    @akshatvishu
    akshatvishu committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c88c4cf View commit details
    Browse the repository at this point in the history

  2. fix(test): Pass the correct dtype at docstring example for moving_pro… 

    …duct in event_set_ops.py
    @akshatvishu
    akshatvishu committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    31c6d7f View commit details
    Browse the repository at this point in the history

  3. fix(test_moving_product): Correct calculation errors in test_with_sam… 

    …pling and test_with_variable_winlen_same_sampling.
    @akshatvishu
    akshatvishu committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e8eb6df View commit details
    Browse the repository at this point in the history