Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using optional.value() in cpp #422

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Avoid using optional.value() in cpp #422

merged 1 commit into from
Apr 16, 2024

Conversation

javiber
Copy link
Collaborator

@javiber javiber commented Apr 12, 2024

This method fails on older macos so we need to replace it by the * operator

@javiber
Avoid using optional .value in cpp
09a77d7 
This method fails on older macos so we need to replace it by the * operator
@javiber javiber requested a review from achoum April 12, 2024 17:38
achoum
achoum approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@achoum achoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@javiber javiber merged commit dc8e17f into main Apr 16, 2024
24 of 25 checks passed
@javiber javiber deleted the fix-optional-macos branch April 16, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achoum achoum achoum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javiber @achoum