Refactor UI #1003
Merged
Refactor UI #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiddinn
reviewed
Oct 22, 2019
timesketch/__init__.py
Outdated
| @@ -39,7 +39,7 @@ | |||
| from timesketch.views.spa import spa_views | |||
|
|
|||
| # Set to true to use the new Vue.js based frontend. | |||
| USE_NEW_FRONTEND = False | |||
| USE_NEW_FRONTEND = True | |||
There was a problem hiding this comment.
did you forget to remove it, or are you ready to enable it?
|
Tests are also failing |
|
Ok, fixed the UI switch, @kiddinn PTAL |
kiddinn
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a more maintainable code base from the start I have refactored the new UI code base to follow some best practices and make it less complex.
A few changes: