Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding aggregation information to the API and API client. #1038

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Adding aggregation information to the API and API client. #1038

merged 4 commits into from
Nov 19, 2019

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Nov 19, 2019

Adding the ability to get more information about aggregation objects into the API and API client.

aggregator

@kiddinn kiddinn requested a review from berggren November 19, 2019 16:53
berggren
berggren previously approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, otherwise LGTM

api_client/python/timesketch_api_client/client.py Outdated Show resolved Hide resolved
@berggren berggren merged commit 857d457 into google:master Nov 19, 2019
@kiddinn kiddinn deleted the aggregations_take_something branch November 20, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiddinn @berggren