Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating client classes into their own files. #1049

Merged
merged 4 commits into from
Nov 22, 2019
Merged

Separating client classes into their own files. #1049

merged 4 commits into from
Nov 22, 2019

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Nov 22, 2019

To prevent some circular dependencies I'm splitting the API client into files, one per class defined.

The only changes made were:

  • Renaming of variables that were overwriting import names
  • Removing u'' from strings in client tests

@kiddinn kiddinn requested a review from berggren November 22, 2019 13:24
berggren
berggren previously approved these changes Nov 22, 2019
View reviewed changes
@kiddinn kiddinn marked this pull request as ready for review November 22, 2019 13:27
berggren
berggren previously approved these changes Nov 22, 2019
View reviewed changes
@kiddinn kiddinn merged commit a82a2c9 into google:master Nov 22, 2019
@kiddinn kiddinn deleted the client_fix branch November 22, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiddinn @berggren