Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Trailing slash in API urls #1064

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Bug fix: Trailing slash in API urls #1064

merged 2 commits into from
Dec 20, 2019

Conversation

berggren
Copy link
Contributor

When run behind a proxy the trailing slash is important so to not redirect to HTTP.

@berggren berggren requested a review from kiddinn December 20, 2019 10:56
@berggren berggren self-assigned this Dec 20, 2019
@berggren berggren added the Bug label Dec 20, 2019
kiddinn
kiddinn approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@kiddinn kiddinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren merged commit ae0e5a6 into master Dec 20, 2019
@berggren berggren deleted the trailing-slash-fix branch December 20, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiddinn kiddinn kiddinn approved these changes

Assignees

@berggren berggren

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berggren @kiddinn