Google Cloud Storage importer #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarontp
previously approved these changes
Feb 10, 2020
contrib/gcs_importer.py
Outdated
| def callback(message): | ||
| """Google PubSub callback. | ||
|
|
||
| This function is called on all incoming messages on the configures topic. |
There was a problem hiding this comment.
Tiny nit: s/configures/configured/
contrib/gcs_importer.py
Outdated
| db_session.add(searchindex) | ||
| db_session.commit() | ||
|
|
||
| if sketch.has_permission(user, 'write'): |
There was a problem hiding this comment.
Maybe instead of not creating a timeline here when we don't have access we could create it and not associate it with the sketch?
|
@aarontp PTAL |
aarontp
previously approved these changes
Feb 10, 2020
contrib/gcs_importer.py
Outdated
| name=searchindex.name, description=searchindex.description, | ||
| sketch=sketch, user=user, searchindex=searchindex) | ||
|
|
||
| # If the user don't have write access to the sketch then create the |
aarontp
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR for this feature. Adds the ability to listen to changes on a Turbinia output to GCS and import automatically.