Adding support for working with stories from the API client, as well as adding aggregation support in the backend #1134

kiddinn · 2020-03-11T16:11:21Z

This PR does quite a few things:

Increments client API version number
Adds a Story class that can add views and text to a story
Adds the ability to delete a story from a sketch in the API
Adds some logging into the API client for failed resource fetches
Adds the ability to create and list stories in the sketch object for the API client
Adds ability to manipulate and work with stories and individual blocks in the API client
Adds the ability for analyzers to add aggregation to stories.
Fixes an issue where API client tests weren't run and fixes broken tests

berggren

Looks good, just a couple of small things

berggren · 2020-03-13T14:30:10Z

api_client/python/timesketch_api_client/sketch.py

+        response_json = response.json()
+        story_dict = response_json.get('objects', [{}])[0]
+        return story.Story(
+            story_id=story_dict.get('id', -1),


don't remember why, cjhanged to zero

berggren · 2020-03-13T14:31:19Z

api_client/python/timesketch_api_client/sketch.py

+
+        Args:
+            story_id: an integer indicating the ID of the story to
+                be fetched. Defaults to None.


Isn't this argument required?

no, either one... if need to provide either one, if you provide story_title the first instance of a story with that title will be returned... made that a bit more clear in the documentation.

hmm, is this really what we want? Oh, a Story for that sketch right? that would make sense

Ok, this is for the sketch. All good

kiddinn · 2020-03-13T14:42:44Z

responded to comments

berggren

LGTM

berggren · 2020-03-13T14:49:48Z

api_client/python/timesketch_api_client/sketch.py

+
+        Args:
+            story_id: an integer indicating the ID of the story to
+                be fetched. Defaults to None.


hmm, is this really what we want? Oh, a Story for that sketch right? that would make sense

berggren · 2020-03-13T14:53:23Z

api_client/python/timesketch_api_client/sketch.py

+
+        Args:
+            story_id: an integer indicating the ID of the story to
+                be fetched. Defaults to None.


Ok, this is for the sketch. All good

kiddinn added 3 commits March 11, 2020 13:50

Bumping API client version

e18ac02

Adding the ability to delete stories, and work with stories in the API

22a5da1

adding the story file

6fac9c8

kiddinn added the New feature label Mar 11, 2020

googlebot added the cla: yes label Mar 11, 2020

kiddinn added 2 commits March 12, 2020 10:11

Adding tests and rewriting how the story API client works.

f4c5745

Fixing running tests to include API client tests, fixing tests.

66336da

kiddinn self-assigned this Mar 12, 2020

kiddinn marked this pull request as ready for review March 12, 2020 12:55

kiddinn requested a review from berggren March 12, 2020 12:56

kiddinn added 12 commits March 12, 2020 13:07

Adding a get_story function

9b060ea

Updating index in blocks

7b8d212

Adding a second newline

068121a

Adding the ability to update text/views ni blocks

aa02c99

linter

f8b6bf1

reverting

c3bb797

Merge branch 'master' into api_stories

1b1b5f8

Adding aggregation objects into stories

bf604f4

Adding aggregation support.

d5fe56b

linter

afae3e8

Minor change

dd753e0

Adding the ability for analyzers to add aggregation into stories.

8001718

kiddinn changed the title ~~Adding the ability to work with stories from the API~~ Adding support for working with stories from the API client, as well as adding aggregation support in the backend Mar 13, 2020

Adding option to define aggregation type in api

36fd840

berggren requested changes Mar 13, 2020

View reviewed changes

kiddinn added 2 commits March 13, 2020 14:37

Merge branch 'master' into api_stories

1f3fe98

Responding to comments

2ef0249

kiddinn requested a review from berggren March 13, 2020 14:42

berggren approved these changes Mar 13, 2020

View reviewed changes

kiddinn merged commit 48b0fc1 into google:master Mar 13, 2020

kiddinn deleted the api_stories branch March 13, 2020 14:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support for working with stories from the API client, as well as adding aggregation support in the backend #1134

Adding support for working with stories from the API client, as well as adding aggregation support in the backend #1134

kiddinn commented Mar 11, 2020 •

edited

Loading

berggren left a comment

berggren Mar 13, 2020

kiddinn Mar 13, 2020

berggren Mar 13, 2020

kiddinn Mar 13, 2020

berggren Mar 13, 2020

berggren Mar 13, 2020

kiddinn commented Mar 13, 2020

berggren left a comment

berggren Mar 13, 2020

berggren Mar 13, 2020

Adding support for working with stories from the API client, as well as adding aggregation support in the backend #1134

Adding support for working with stories from the API client, as well as adding aggregation support in the backend #1134

Conversation

kiddinn commented Mar 11, 2020 • edited Loading

berggren left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kiddinn commented Mar 13, 2020

berggren left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kiddinn commented Mar 11, 2020 •

edited

Loading