Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTY check for providing missing config values #2850

Merged
merged 7 commits into from
Sep 7, 2023

Conversation

ramo-j
Copy link
Contributor

@ramo-j ramo-j commented Jul 19, 2023

This change adds a check for a TTY before asking for missing config values. In scenarios where a TTY is not present (such as downstreams' dftimewolf using curses display) the UI will block indefinitely, but a user will not be able to tell why.

Checks

  • All tests succeed.
  • Unit tests added.
  • e2e tests added.
  • Documentation updated.

Closing issues

Closes #2849

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren marked this pull request as ready for review September 7, 2023 09:55
@berggren berggren merged commit 49cad21 into google:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot provide missing config values if no TTY available
3 participants