Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DFIQ context to SearchHistory #2957

Merged
merged 15 commits into from
Oct 25, 2023
Merged

Add DFIQ context to SearchHistory #2957

merged 15 commits into from
Oct 25, 2023

Conversation

berggren
Copy link
Contributor

@berggren berggren commented Oct 25, 2023 •
edited
Loading

To test this PR the database schema has to be migrated. In the dev container:

cd /usr/local/src/timesketch/timesketch
tsctl db stamp 5c3ba044dc64
tsctl db upgrade

You also need to download the latest DFIQ repo and make it available to you container in e.g. /etc/timesketch

git clone https://github.com/google/dfiq.git

Configure /etc/timesketch/timesketch.conf in you dev container:

DFIQ_PATH = '/etc/timesketch/dfiq/'
Screenshot 2023-10-25 at 09 31 31 Screenshot 2023-10-25 at 09 31 54

closes #2907

@berggren berggren self-assigned this Oct 25, 2023
@berggren berggren added this to the Release: 20231025 milestone Oct 25, 2023
@berggren berggren requested a review from jkppr October 25, 2023 09:03
@berggren berggren marked this pull request as ready for review October 25, 2023 09:03
jkppr
jkppr approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested & lgtm

two small ux nits, nothing blocking

timesketch/frontend-ng/src/components/Scenarios/ContextCard.vue Outdated Show resolved Hide resolved
timesketch/frontend-ng/src/components/Scenarios/ContextCard.vue Show resolved Hide resolved
timesketch/frontend-ng/src/components/Scenarios/Question.vue Show resolved Hide resolved
@berggren berggren merged commit d0d6ae9 into master Oct 25, 2023
27 checks passed
@berggren berggren deleted the dfiq-history-context branch October 25, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkppr jkppr jkppr approved these changes

Assignees

@berggren berggren

Labels
None yet
Projects
None yet
Milestone
Release: 20231025
Development

Successfully merging this pull request may close these issues.

Add DFIQ context to search history
2 participants
@berggren @jkppr