Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix for context links #2962

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Oct 26, 2023

This PR fixes some minor bugs introduced in the new context link handling and with the unfurl dialog UI.

  • Activate context link VT hash lookup by default in the configuration for a better user experience.
    • This will also prevent new Timesketch setups with v20231025 to crash the contextlinks.py api endpoint.
  • Fix a bug in the contextlinks.py API endpoint. When the new configuration was applied but no linked_service was defined, the API endpoint threw an exception!
  • Fix UI bug and formatting in the unfurl dialog.
    • The unfurl dialog now shows the call to action Select a node in the graph below to get more information. only after the graph loaded successfully.
    • The Node context and input URL are now displayed as code blocks for better readability and consistency with the redirect warning dialog URLs.

+ Fix a bug in the contextlink API when there is no linked_service defined
+ Fix UI bug and formatting in the unfurl dialog
@jkppr jkppr added the Bug label Oct 26, 2023
@jkppr jkppr requested a review from berggren October 26, 2023 15:47
@jkppr jkppr self-assigned this Oct 26, 2023
@jkppr jkppr merged commit d2b38e1 into google:master Oct 27, 2023
24 checks passed
@jkppr jkppr deleted the fix_context_link_unfurl branch October 27, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants