Adding and updating tooltips for icons #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling New Updates
* Add tooltips where v-icons have no explanation. * Update tooltips to follow new UX guidance.
4 tasks
Co-authored-by: Johan Berggren <jberggren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fork of #2952 and builds on the work already done there.
Context: I have met with our UX advisor and updated/unified our guidance on how tooltips should be used in the Timesketch project. (#2982)
Short version: For the sake of effort & efficiency, we will rely on the browser generated tooltips for the title attribute by default.
This PR updates Timesketch to follow this new guidance:
v-iconelements that have no descriptive text next to them.v-tooltipelements used and replacing them with a title attribute.Closing issues
closes #2693
co-authors: @bryankhor07 @lemonshark05 @gstgrace