Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timesketch API client: Adding type check to prevent error. #3030

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Timesketch API client: Adding type check to prevent error. #3030

merged 2 commits into from
Feb 1, 2024

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Jan 30, 2024

Fixes the issue described in #3029 by checking if the index is of type string before checking isdigit().

Closing issues

closes #3029

@jkppr jkppr added this to the Release: 20240207 milestone Jan 30, 2024
@jkppr jkppr requested a review from berggren January 30, 2024 15:18
@jkppr jkppr self-assigned this Jan 30, 2024
@jkppr jkppr merged commit 564ff84 into google:master Feb 1, 2024
24 checks passed
@jkppr jkppr deleted the 3029-fix-api-client branch February 1, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees

@jkppr jkppr

Labels
API client
Projects
None yet
Milestone
Release: 20240207
Development

Successfully merging this pull request may close these issues.

Timesketch API client: Search object indices list bug
2 participants
@jkppr @berggren