Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profile and settings support #3048

Merged
merged 6 commits into from
Mar 20, 2024
Merged

User profile and settings support #3048

merged 6 commits into from
Mar 20, 2024

Conversation

berggren
Copy link
Contributor

This PR adds server stored user settings.

Screenshot 2024-03-15 at 10 16 02 Screenshot 2024-03-15 at 10 16 12

@berggren berggren changed the title Add user UI settings Add user UI Profile with settings support Mar 15, 2024
@berggren berggren changed the title Add user UI Profile with settings support User profile and settings support Mar 15, 2024
@berggren berggren requested a review from jkppr March 15, 2024 14:49
@berggren berggren marked this pull request as ready for review March 15, 2024 14:49
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just two small suggestions.

Everything UI&UX wise (e.g. close button etc) we can do in a follow-up PR.

@jkppr jkppr merged commit 1afccb4 into master Mar 20, 2024
27 checks passed
@jkppr jkppr deleted the user-settings branch March 20, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants