Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzers fetching active sessions #3093

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix analyzers fetching active sessions #3093

merged 1 commit into from
May 14, 2024

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented May 14, 2024

This PR fixes an issue that was discovered after releasing version 20240805 where an invalid API path that existed before is now returning a 404 error.

The problem was a unused parameter this.store in the fetchActiveAnalyses function. Removing the parameter from the function call fixes the URL path and even speeds up the analyzer UI 👍

Closing issues

closes #3092

@jkppr jkppr requested a review from berggren May 14, 2024 15:00
@jkppr jkppr self-assigned this May 14, 2024
@jkppr jkppr requested a review from Annoraaq May 14, 2024 15:27
Copy link
Collaborator

@Annoraaq Annoraaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkppr jkppr merged commit 74b6dee into google:master May 14, 2024
24 checks passed
@jkppr jkppr deleted the fix_3092 branch May 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API returns 404
2 participants