Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeline selection to visualization editor #3140

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

sydp
Copy link
Collaborator

@sydp sydp commented Aug 15, 2024

This PR adds a timeline selection component to the visualization editor to allow the user to select specific timelines when creating aggregations/charts.

  • All tests succeed.
  • Unit tests added.
  • e2e tests added.
  • Documentation updated.

@sydp sydp marked this pull request as ready for review August 15, 2024 20:44
@jkppr jkppr added the Frontend label Aug 15, 2024
@sydp sydp requested a review from jkppr August 15, 2024 20:51
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, thanks for adding those filters.

Please check the comments below.

Additionally, can you add an indicator on what timelines a saved visualization was performed? E.g. looking at this screenshot, it is not clear that the data only comes from the BitsClient timeline if I would not have written it into the title.

image

…ionEditor.vue

Co-authored-by: Janosch <99879757+jkppr@users.noreply.github.com>
@sydp
Copy link
Collaborator Author

sydp commented Aug 16, 2024

Overall looking good, thanks for adding those filters.

Please check the comments below.

Additionally, can you add an indicator on what timelines a saved visualization was performed? E.g. looking at this screenshot, it is not clear that the data only comes from the BitsClient timeline if I would not have written it into the title.

image

If i understand correctly, we want a separate visual element that displays the underlying timeline being used? Does this have to be in the chart itself or somewhere else in the UI? Perhaps we need to design/mock this further before implementing?

In saying that, imho I think this is best left to the analyst (or the analyzer) creating the chart to set the title value to appropriately reflect what is being displayed. Perhaps an auto-generated (template or GenAI suggested) title based on the field, aggregation and timelines selected could achieve this?

Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we will tackle the open UX topics in a follow-up PR. For now it is more important to get the Timeline filter in for the next release.

@jkppr jkppr merged commit 15f4a46 into google:master Aug 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants