Add query string filtering to Visualizations #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Provide only fields that exist in all selected timelines for the aggregation. * Minor UI fix for the EventList * Dynamically sized the placeholder picture
|
@sydp overall looks really good, thanks for the PR! For a better UX I added some changes:
Please see the commit dcf8edb and let me know what you think. |
lgtm @jkppr, thx for the additions |
3 tasks
|
Adding a task: Research more efficient ways to gather unique fields. #3200 |
jkppr
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds query string filtering when aggregating events used in visualizations.