Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in llm_summarize and introduce initial tests #3296

Merged
merged 25 commits into from
Feb 12, 2025

Conversation

itsmvd
Copy link
Collaborator

@itsmvd itsmvd commented Feb 12, 2025

No description provided.

@itsmvd itsmvd marked this pull request as ready for review February 12, 2025 11:40
@itsmvd itsmvd requested a review from jkppr February 12, 2025 11:41
@jkppr jkppr added the Bug label Feb 12, 2025
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the "no-results" bug and adding tests.

Approving now, but please fix the failing unit-test before merging.

@jkppr jkppr merged commit b798bd7 into google:master Feb 12, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants