Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct link to specific event (#414) #503

Merged
merged 2 commits into from
Dec 17, 2017
Merged

Add direct link to specific event (#414) #503

merged 2 commits into from
Dec 17, 2017

Conversation

csash
Copy link
Contributor

@csash csash commented Dec 17, 2017

Resubmitting because my git skills suck... sorry

Adds a link above the comment section in the event detail view to a query that returns the event being viewed. I figure this probably won't get enough use to warrant its own icon in the event list and you'll probably already be looking at the detail view for any event you care about enough to want a direct link for it.

Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@berggren
Copy link
Contributor

CLA warning is wrong. This happens when you hit the update this branch button on GitHub. Was green before I hit the button.

@berggren berggren merged commit 478b662 into google:master Dec 17, 2017
@csash csash deleted the 414-linktoevent branch December 17, 2017 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants