Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG logo #527

Merged
merged 2 commits into from
Jan 18, 2018
Merged

Add SVG logo #527

merged 2 commits into from
Jan 18, 2018

Conversation

berggren
Copy link
Contributor

@berggren berggren commented Jan 17, 2018

screen shot 2018-01-17 at 12 38 21

@berggren berggren self-assigned this Jan 17, 2018
@berggren berggren requested a review from tomchop January 17, 2018 11:45
transform="translate(-12.613341,-27.138357)"
id="layer1">
<g
id="text12"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use more explicit variables names

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I will follow up and update the SVG RFC when time permits ;)

Copy link
Collaborator

@tomchop tomchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best PR so far.

@berggren berggren merged commit 9232e8b into master Jan 18, 2018
@berggren berggren deleted the logo-should-be-svg branch January 18, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants