Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSV files using non-standard delimiters #539

Merged
merged 3 commits into from
Feb 2, 2018
Merged

Conversation

adamjnichols
Copy link
Contributor

Tested to work with tab, pipe, hash, and others.

One thing about this that I really don't love is that the current class structure prevents the use of Option() within only the CSV object, meaning that you are able to pass an (ignored) option for --delimiter into jsonl2ts. It's not a huge issue but refactoring to correct it is.

Fixes #337

Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@berggren berggren merged commit 30fba6a into master Feb 2, 2018
@berggren berggren deleted the ajn-tsv branch February 2, 2018 08:29
@berggren
Copy link
Contributor

berggren commented Feb 2, 2018

CLA error is false. IT's a bug when you hit update branch button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants